Conversation
|
Failure in dtslint is due to: https://github.com/Microsoft/dtslint/blob/master/docs/no-unnecessary-generics.md |
ChristianMurphy
left a comment
There was a problem hiding this comment.
I won't block this approach.
But I still do have reservations, and tend to think casting is a better solution.
|
I don’t have an informed enough opinion on this matter or TypeScript, so I’d abstain from voting for or against it: I created this PR based on a suggestion by @Rokt33r to continue the conversation. I’m interested in hearing about the downsides from Junyoung. @ChristianMurphy Is casting a solution we can apply here in unified, or does that happen on the user’s side? |
It would happen on the user's side, it's something we could document. |
|
That doesn’t sound too bad... |
|
@ChristianMurphy How should we document that? Here? https://github.com/unifiedjs/unified#returns-3 …maybe in also here? https://github.com/unifiedjs/unified#returns-6 …or should it go in *-react and the other stringifier plugins? |
This option sounds good to me. |
Should be ideal. Until it is released, we could notice users to do like |
|
@wooorm And I'm afraid that my decision is right because I'm not using remark with typescript now. My work is stale because I don't know which version of typescript should I support. remarkjs/remark#383 (comment) If you give some kind of confirmation, I could start working again. In my opinion, we can ignore old versions of typescript until the type definitions for unified ecosystem are settled. spectrum: TypeScript version(s) supported? |
|
Alright, I’ll close this PR. I’d appreciate if other people could do the same when needed to the other plugins returning non-strings.
Sorry about that. I don’t have an informed opinion. Going with current (3?) seems good to me? Thanks for working on types! |
|
I guess we need higher than v3.1 at least. Then, I'll ignore lower version support until types are settled to unified ecosystem! I could start working again from this weekend! |
|
Awesome, sounds good to me! |
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <tituswormer@gmail.com> Reviewed-by: Junyoung Choi <fluke8259@gmail.com> Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Co-authored-by: Junyoung Choi <fluke8259@gmail.com> Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
Note: there are reservations for this approach: #47 (comment).
Closes GH-47.
/cc @Rokt33r