Fix Parser and Compiler types#64
Merged
wooorm merged 2 commits intounifiedjs:masterfrom Jul 17, 2019
clavin:fix-parser-compiler-types
Merged
Fix Parser and Compiler types#64wooorm merged 2 commits intounifiedjs:masterfrom clavin:fix-parser-compiler-types
wooorm merged 2 commits intounifiedjs:masterfrom
clavin:fix-parser-compiler-types
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
/cc @Rokt33r |
Member
ChristianMurphy
left a comment
There was a problem hiding this comment.
Thanks @clavin!
A couple questions on the changes below.
Contributor
Author
|
Oh! 😳Nice catch on the object methods. Those should be patched up 👍 I also noticed that the |
ChristianMurphy
approved these changes
Jul 17, 2019
Member
ChristianMurphy
left a comment
There was a problem hiding this comment.
LGTM, thanks @clavin!
Member
|
@wooorm these are fixes and can go in a patch release. |
wooorm
approved these changes
Jul 17, 2019
wooorm
pushed a commit
to remarkjs/remark
that referenced
this pull request
Jul 20, 2019
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <tituswormer@gmail.com> Reviewed-by: Junyoung Choi <fluke8259@gmail.com> Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Co-authored-by: Junyoung Choi <fluke8259@gmail.com> Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current typings are defined such that Parsers and Compilers (and their respective functional variants) take
VFileCompatiblearguments (and, in the case of Parsers, has the wrong number of arguments). The truth is the spec states that they should acceptVFileobjects (and Parsers take two arguments), and the underlying implementation aligns with this:vfile()'d argumentvfile()'d argumentfilepassed to both isvfile(doc)in both.index.js.Looking for the same inconsistency in the typings, I checked other occurrences of
VFileCompatiblein theindex.d.tsfile. The remaining occurrences align with the spec--that is, anywhereVFileCompatibleshows up in the typings, the spec explicitly states "any value accepted byvfile()".