types: allow any number of settings to be passed to a plugin#62
Merged
wooorm merged 1 commit intounifiedjs:masterfrom Jul 15, 2019
Merged
Conversation
Member
Author
|
/cc @Rokt33r |
ChristianMurphy
commented
Jul 13, 2019
This comment has been minimized.
This comment has been minimized.
ChristianMurphy
commented
Jul 13, 2019
ChristianMurphy
commented
Jul 13, 2019
ChristianMurphy
commented
Jul 13, 2019
ChristianMurphy
commented
Jul 13, 2019
uses variadic function with tuple based type checking to ensure settings and parameters match up.
0cdfe28 to
b7cf3ad
Compare
Rokt33r
approved these changes
Jul 15, 2019
Member
Rokt33r
left a comment
There was a problem hiding this comment.
Looks much better. :) I hope typescript could check the usage with PluginTuple one day.
Member
Author
|
This adds a new feature, if merged, it should go in a minor release. |
wooorm
approved these changes
Jul 15, 2019
wooorm
pushed a commit
to remarkjs/remark
that referenced
this pull request
Jul 20, 2019
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <tituswormer@gmail.com> Reviewed-by: Junyoung Choi <fluke8259@gmail.com> Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Co-authored-by: Junyoung Choi <fluke8259@gmail.com> Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
uses variadic function with tuple based type checking to ensure settings and parameters match up.
resolves #60 by removing extra settings in favor of a variadic function.
There are some trade offs here, I've documented them to the best of my ability below.