Allow processors to declare options/settings with types#59
Merged
wooorm merged 2 commits intounifiedjs:masterfrom Jul 12, 2019
Merged
Allow processors to declare options/settings with types#59wooorm merged 2 commits intounifiedjs:masterfrom
wooorm merged 2 commits intounifiedjs:masterfrom
Conversation
remark, rehype, etc can be passed settings. This creates a generic type that allows the language specific instances of unified to declare what options are supported.
Member
Author
|
/cc @Rokt33r |
This comment has been minimized.
This comment has been minimized.
also rename T and S to S and S2 to better match 'settings' param and 'Settings' base type.
wooorm
approved these changes
Jul 12, 2019
Member
Author
|
@wooorm this adds a new feature, this should be included in a minor release. |
Member
Author
|
ideally it would be good for this to go out at the same time as #61 |
Member
|
If someone can review 61 tonight I’ll cut 8.2.0 tomorrow! |
wooorm
pushed a commit
to remarkjs/remark
that referenced
this pull request
Jul 20, 2019
Related to unifiedjs/unified#53. Related to unifiedjs/unified#54. Related to unifiedjs/unified#56. Related to unifiedjs/unified#57. Related to unifiedjs/unified#58. Related to unifiedjs/unified#59. Related to unifiedjs/unified#60. Related to unifiedjs/unified#61. Related to unifiedjs/unified#62. Related to unifiedjs/unified#63. Related to unifiedjs/unified#64. Related to #426. Reviewed-by: Titus Wormer <tituswormer@gmail.com> Reviewed-by: Junyoung Choi <fluke8259@gmail.com> Reviewed-by: Christian Murphy <christian.murphy.42@gmail.com> Co-authored-by: Junyoung Choi <fluke8259@gmail.com> Co-authored-by: Christian Murphy <christian.murphy.42@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remark, rehype, etc can be passed settings.
This creates a generic type that allows the language specific instances of
unifiedto declare what options are supported.Based off discussion from remarkjs/remark#383 (comment)