ROX-31760: Fix PF codemod color replacement#17897
Merged
dvail merged 6 commits intodv/ROX-28622-pf-6from Dec 3, 2025
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #17897 +/- ##
=====================================================
- Coverage 49.45% 49.45% -0.01%
=====================================================
Files 2699 2699
Lines 198270 198270
=====================================================
- Hits 98063 98057 -6
- Misses 92602 92606 +4
- Partials 7605 7607 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2858333 to
f2eec35
Compare
296b7c8 to
ade69d3
Compare
This was referenced Nov 24, 2025
ade69d3 to
f0790ba
Compare
dvail
commented
Nov 25, 2025
This was referenced Nov 25, 2025
ui/apps/platform/src/Components/CVEStackedPill/CVEStackedPill.jsx
Outdated
Show resolved
Hide resolved
99c3003 to
cc2560f
Compare
8f5cc5b to
ad01998
Compare
pedrottimark
reviewed
Dec 2, 2025
ui/apps/platform/src/Components/PatternFly/TableErrorComponent.tsx
Outdated
Show resolved
Hide resolved
pedrottimark
reviewed
Dec 2, 2025
pedrottimark
reviewed
Dec 2, 2025
ui/apps/platform/src/Containers/Clusters/ClusterLabelsTable.tsx
Outdated
Show resolved
Hide resolved
dvail
commented
Dec 2, 2025
ui/apps/platform/src/Components/PatternFly/ResourceIcon/ResourceIcon.css
Show resolved
Hide resolved
dvail
commented
Dec 2, 2025
ui/apps/platform/src/Containers/AccessControl/AccessScopes/EffectiveAccessScopeTable.tsx
Show resolved
Hide resolved
dvail
commented
Dec 2, 2025
dvail
commented
Dec 2, 2025
ui/apps/platform/src/Containers/MainPage/Navigation/NavigationContent.tsx
Show resolved
Hide resolved
dvail
commented
Dec 2, 2025
dvail
commented
Dec 2, 2025
ui/apps/platform/src/Containers/PolicyCategories/PolicyCategoriesList.tsx
Show resolved
Hide resolved
dvail
commented
Dec 2, 2025
ui/apps/platform/src/Containers/Risk/Process/ProcessDiscoveryCardHeader.tsx
Show resolved
Hide resolved
pedrottimark
approved these changes
Dec 2, 2025
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
You get an A for tenacity.
Obvious opportunity to encapsulate colors for ExclamationCircleIcon and so on.
dvail
added a commit
that referenced
this pull request
Dec 3, 2025
dvail
added a commit
that referenced
this pull request
Dec 3, 2025
dvail
added a commit
that referenced
this pull request
Dec 9, 2025
dvail
added a commit
that referenced
this pull request
Jan 7, 2026
dvail
added a commit
that referenced
this pull request
Jan 30, 2026
dvail
added a commit
that referenced
this pull request
Feb 3, 2026
dvail
added a commit
that referenced
this pull request
Feb 6, 2026
dvail
added a commit
that referenced
this pull request
Feb 10, 2026
dvail
added a commit
that referenced
this pull request
Feb 11, 2026
dvail
added a commit
that referenced
this pull request
Feb 12, 2026
dvail
added a commit
that referenced
this pull request
Feb 13, 2026
dvail
added a commit
that referenced
this pull request
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17809 for more info on the PF migration.
Description
This change replaces all
tmpcolor variables inserted by the PatternFly code mods to align with what we expect in the UI. The colors were chosen based on the semantic meaning of the new PatternFly tokens as closely as possible, rather than finding the color in v6 that happened to be closest to the color in v5.AI was not used to help with this PR, as the first attempt was nowhere near satisfactory.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Samples of chosen colors. This PR does not address the numerous layout issues.
