ROX-31761: Migrate screen reader utility class#17935
Merged
dvail merged 2 commits intodv/ROX-28622-pf-6from Dec 3, 2025
Merged
ROX-31761: Migrate screen reader utility class#17935dvail merged 2 commits intodv/ROX-28622-pf-6from
dvail merged 2 commits intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #17935 +/- ##
====================================================
Coverage ? 49.36%
====================================================
Files ? 2699
Lines ? 198960
Branches ? 0
====================================================
Hits ? 98208
Misses ? 93136
Partials ? 7616
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ea13b0e to
006f4c0
Compare
8bc545e to
48aa3a2
Compare
This was referenced Nov 25, 2025
This was referenced Nov 25, 2025
pedrottimark
approved these changes
Nov 25, 2025
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
Aha, because I did not circle back after PatternFly 5.4 upgrade to replace temporary work-around for accessibility issues with screenReaderText prop. Codemod might not consider it as a public class, and rightfully so.
006f4c0 to
ae71e12
Compare
48aa3a2 to
03ebdd0
Compare
ae71e12 to
6e5b59e
Compare
03ebdd0 to
e2c25d4
Compare
Base automatically changed from
dv/ROX-31762-remove-legacy-dark-mode-theme-refs
to
dv/ROX-28622-pf-6
December 3, 2025 13:48
dvail
added a commit
that referenced
this pull request
Dec 3, 2025
dvail
added a commit
that referenced
this pull request
Dec 9, 2025
dvail
added a commit
that referenced
this pull request
Jan 7, 2026
dvail
added a commit
that referenced
this pull request
Jan 30, 2026
dvail
added a commit
that referenced
this pull request
Feb 3, 2026
dvail
added a commit
that referenced
this pull request
Feb 6, 2026
dvail
added a commit
that referenced
this pull request
Feb 10, 2026
dvail
added a commit
that referenced
this pull request
Feb 11, 2026
dvail
added a commit
that referenced
this pull request
Feb 12, 2026
dvail
added a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As titled. It isn't clear why this wasn't handled via the CODEMOD, as it appears to be a simple one-to-one migrations.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Before
After
