ROX-31766: Fix colors of logos and login page#17950
Merged
dvail merged 4 commits intodv/ROX-28622-pf-6from Dec 3, 2025
Merged
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #17950 +/- ##
====================================================
Coverage ? 49.35%
====================================================
Files ? 2699
Lines ? 198960
Branches ? 0
====================================================
Hits ? 98195
Misses ? 93146
Partials ? 7619
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9 tasks
| return ( | ||
| <div> | ||
| <Title headingLevel="h2" size={TitleSizes['3xl']} className="pb-12"> | ||
| <Title headingLevel="h2" size={TitleSizes['3xl']} className="pf-v6-u-pb-xl"> |
Contributor
There was a problem hiding this comment.
Incremental step makes sense. When we circle back later to replace redux form elements, Flex layout seems possible to replace className props.
Letting my fingers do the brainstorming, maybe a lint rule/tool with ignores to report PatternFly vertical margin/padding classes for investigation?
pedrottimark
approved these changes
Nov 25, 2025
Contributor
pedrottimark
left a comment
There was a problem hiding this comment.
For visibility, replaced fill="#FFFFFF" with fill:#000000 in images correct?
9 tasks
96a8b26 to
e4aba8f
Compare
5a592fe to
8ce63f4
Compare
e4aba8f to
73ae758
Compare
8ce63f4 to
cc491d0
Compare
Base automatically changed from
dv/ROX-31763-font-family-css-var-migrate
to
dv/ROX-28622-pf-6
December 3, 2025 13:49
dvail
added a commit
that referenced
this pull request
Dec 3, 2025
dvail
added a commit
that referenced
this pull request
Dec 9, 2025
dvail
added a commit
that referenced
this pull request
Jan 7, 2026
dvail
added a commit
that referenced
this pull request
Jan 30, 2026
dvail
added a commit
that referenced
this pull request
Feb 3, 2026
dvail
added a commit
that referenced
this pull request
Feb 6, 2026
dvail
added a commit
that referenced
this pull request
Feb 10, 2026
dvail
added a commit
that referenced
this pull request
Feb 11, 2026
dvail
added a commit
that referenced
this pull request
Feb 12, 2026
dvail
added a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17809 for more info on the PF migration.
Description
Fixes the default colors of the main logo text and login page to fit with the PF6 light theme.
User-facing documentation
Testing and quality
Automated testing
How I validated my change