ROX-31762: Remove references to unused dark theme#17934
Merged
dvail merged 1 commit intodv/ROX-28622-pf-6from Dec 3, 2025
Merged
ROX-31762: Remove references to unused dark theme#17934dvail merged 1 commit intodv/ROX-28622-pf-6from
dvail merged 1 commit intodv/ROX-28622-pf-6from
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
|
Skipping CI for Draft Pull Request. |
9 tasks
ade69d3 to
f0790ba
Compare
ea13b0e to
006f4c0
Compare
This was referenced Nov 25, 2025
This was referenced Nov 25, 2025
8f5cc5b to
ad01998
Compare
006f4c0 to
ae71e12
Compare
pedrottimark
approved these changes
Dec 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dv/ROX-28622-pf-6 #17934 +/- ##
====================================================
Coverage ? 49.35%
====================================================
Files ? 2699
Lines ? 198960
Branches ? 0
====================================================
Hits ? 98205
Misses ? 93138
Partials ? 7617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
dv/ROX-31760-pf-codemod-color-fix
to
dv/ROX-28622-pf-6
December 3, 2025 13:41
f25eac4 to
ae2996c
Compare
ae71e12 to
6e5b59e
Compare
dvail
added a commit
that referenced
this pull request
Dec 3, 2025
dvail
added a commit
that referenced
this pull request
Dec 9, 2025
dvail
added a commit
that referenced
this pull request
Jan 7, 2026
dvail
added a commit
that referenced
this pull request
Jan 30, 2026
dvail
added a commit
that referenced
this pull request
Feb 3, 2026
dvail
added a commit
that referenced
this pull request
Feb 6, 2026
dvail
added a commit
that referenced
this pull request
Feb 10, 2026
dvail
added a commit
that referenced
this pull request
Feb 11, 2026
dvail
added a commit
that referenced
this pull request
Feb 12, 2026
dvail
added a commit
that referenced
this pull request
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #17809 for more info on the PF migration.
Description
Dark theme was only partially implemented in PF4, and was fully disabled in PF5. Since dark theme is not on the priority list for the near future, and since existing dark theme code likely needs a rewrite anyway, we will delete it here and start clean if/when we decide to implement.
Also fixes the mini dark-theme color switched for embedded code viewer components.
User-facing documentation
Testing and quality
Automated testing
How I validated my change