ROX-33417: add timestamptz support via proto tag#19249
ROX-33417: add timestamptz support via proto tag#19249dashrews78 wants to merge 4 commits intomasterfrom
Conversation
|
This change is part of the following stack: Change managed by git-spice. |
|
Images are ready for the commit at 6ac7ba2. To use with deploy scripts, first |
|
/retest |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19249 +/- ##
=======================================
Coverage 49.63% 49.64%
=======================================
Files 2679 2679
Lines 202130 202149 +19
=======================================
+ Hits 100319 100348 +29
+ Misses 94333 94324 -9
+ Partials 7478 7477 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add DateTimeTZ DataType so that timestamp proto fields tagged with `sql:"type(timestamptz)"` generate PostgreSQL `timestamptz` columns instead of `timestamp`. The search framework reuses the existing newTimeQuery path, keeping query behavior identical. Update code-generation templates (store, singleton, migration_tool) to emit protocompat.NilOrTime for datetimetz fields. Add a timestamptz field to TestSingleKeyStruct to exercise the new code path. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add timestamptz field to TestStruct proto and add TestTimeTZ and TestTimeTZHighlights integration tests mirroring the existing timestamp tests. These exercise the full DateTimeTZ code path end-to-end: schema generation, pgtype.Timestamptz scanning, and newTimeQuery dispatch. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
18cb187 to
6ac7ba2
Compare
|
/retest |
|
/test ocp-4-20-operator-e2e-tests |
|
/test ocp-4-20-qa-e2e-tests |
|
@dashrews78: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Description
Add DateTimeTZ DataType so that timestamp proto fields tagged with
sql:"type(timestamptz)"generate PostgreSQLtimestamptzcolumnsinstead of
timestamp. The search framework reuses the existingnewTimeQuery path, keeping query behavior identical.
Update code-generation templates (store, singleton, migration_tool) to
emit protocompat.NilOrTime for datetimetz fields. Add a timestamptz
field to TestSingleKeyStruct to exercise the new code path.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
User-facing documentation
Testing and quality
Automated testing
How I validated my change
UT sufficient for now. Real testing will occur when types such as virtual machines V2 begin to use it.