ROX-28697: use Walk instead of GetAll in logimbue and policycategory#14742
Merged
ROX-28697: use Walk instead of GetAll in logimbue and policycategory#14742
Conversation
5b5956e to
1e43af3
Compare
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
1e43af3 to
be6379e
Compare
Contributor
|
Images are ready for the commit at 3c6be8e. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14742 +/- ##
==========================================
- Coverage 49.20% 48.88% -0.32%
==========================================
Files 2533 2546 +13
Lines 185529 186956 +1427
==========================================
+ Hits 91287 91400 +113
- Misses 87005 88312 +1307
- Partials 7237 7244 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2331599 to
343de05
Compare
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
343de05 to
3c6be8e
Compare
This was referenced Mar 27, 2025
rhybrillou
approved these changes
Apr 3, 2025
Contributor
rhybrillou
left a comment
There was a problem hiding this comment.
LGTM.
Thanks for taking the initiative of this refactor.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We are using GetAll in logimbue this is not optimal as we load all data into memory and then convert them to json and write to zip. With this change we can do it one by one in a stream.
This PR removes writer package as it's now part of the service as it was the only place it was used.
Testing
Automated testing
How I validated my change
CI