Skip to content

ROX-28697: use Walk instead of GetAll in service identites#14759

Merged
janisz merged 3 commits intomasterfrom
ROX-15902_use_walk_in_serviceidentities
Apr 7, 2025
Merged

ROX-28697: use Walk instead of GetAll in service identites#14759
janisz merged 3 commits intomasterfrom
ROX-15902_use_walk_in_serviceidentities

Conversation

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 26, 2025

Images are ready for the commit at bb90ac1.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-321-gbb90ac1e76.

@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (8e68c6a) to head (bb90ac1).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
...tral/serviceidentities/datastore/datastore_impl.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #14759      +/-   ##
==========================================
- Coverage   49.20%   49.01%   -0.19%     
==========================================
  Files        2533     2546      +13     
  Lines      185529   186951    +1422     
==========================================
+ Hits        91287    91639     +352     
- Misses      87005    88061    +1056     
- Partials     7237     7251      +14     
Flag Coverage Δ
go-unit-tests 49.01% <75.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Mar 27, 2025
@janisz
Copy link
Contributor Author

janisz commented Mar 27, 2025

/retest

janisz added 2 commits April 4, 2025 14:11
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz merged commit 09c593d into master Apr 7, 2025
92 checks passed
@janisz janisz deleted the ROX-15902_use_walk_in_serviceidentities branch April 7, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants