ROX-28697: use Walk instead of GetAll in backup#14779
Merged
Conversation
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
Contributor
|
Images are ready for the commit at 91766ba. To use with deploy scripts, first |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #14779 +/- ##
==========================================
- Coverage 49.20% 49.01% -0.19%
==========================================
Files 2533 2546 +13
Lines 185529 186953 +1424
==========================================
+ Hits 91287 91636 +349
- Misses 87005 88065 +1060
- Partials 7237 7252 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
This was referenced Mar 27, 2025
rhybrillou
approved these changes
Apr 4, 2025
Contributor
rhybrillou
left a comment
There was a problem hiding this comment.
Looks good.
I reported on another PR what I think is a risk of data corruption in the telemetry data gathering. Please consider addressing it in all GetAll -> Walk PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Automated testing
How I validated my change
CI