Skip to content

ROX-28697: use Walk instead of GetAll in cloud sources#14781

Merged
janisz merged 2 commits intomasterfrom
ROX-15902_use_walk_in_cloudsources
Apr 7, 2025
Merged

ROX-28697: use Walk instead of GetAll in cloud sources#14781
janisz merged 2 commits intomasterfrom
ROX-15902_use_walk_in_cloudsources

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Mar 27, 2025 •
edited
Loading

Description

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz janisz requested a review from a team as a code owner March 27, 2025 10:17
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 27, 2025 •
edited
Loading

Images are ready for the commit at 4deffdd.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-320-g4deffdde03.

@codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 46.87500% with 17 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (8e68c6a) to head (4deffdd).
Report is 90 commits behind head on master.

Files with missing lines Patch % Lines
central/cloudsources/manager/manager.go 43.33% 17 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14781      +/-   ##
==========================================
- Coverage   49.20%   49.01%   -0.20%     
==========================================
  Files        2533     2546      +13     
  Lines      185529   186947    +1418     
==========================================
+ Hits        91287    91629     +342     
- Misses      87005    88065    +1060     
- Partials     7237     7253      +16
Flag Coverage Δ
go-unit-tests 49.01% <46.87%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz
ROX-28697: use Walk instead of GetAll in cloud sources
833b34c 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the ROX-15902_use_walk_in_cloudsources branch from ca0eb65 to 833b34c Compare March 27, 2025 16:36
This was referenced Mar 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@janisz
foreach
4deffdd 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Apr 7, 2025
@janisz janisz merged commit 9ef2e4d into master Apr 7, 2025
92 of 93 checks passed
@janisz janisz deleted the ROX-15902_use_walk_in_cloudsources branch April 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janisz @rhacs-bot @rhybrillou