Skip to content

ROX-28697: use Walk instead of GetAll in image integrations#14784

Merged
janisz merged 1 commit intomasterfrom
ROX-15902_use_walk_in_imageintegration
Apr 7, 2025
Merged

ROX-28697: use Walk instead of GetAll in image integrations#14784
janisz merged 1 commit intomasterfrom
ROX-15902_use_walk_in_imageintegration

Conversation

@janisz
Copy link
Copy Markdown
Contributor

@janisz janisz commented Mar 27, 2025 •
edited
Loading

Description

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 27, 2025 •
edited
Loading

Images are ready for the commit at 8401ffd.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-401-g8401ffd273.

@janisz
Copy link
Copy Markdown
Contributor Author

janisz commented Mar 27, 2025

/retest

This was referenced Mar 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 35.71429% with 9 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (9550949) to head (8401ffd).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
central/imageintegration/datastore/singleton.go 0.00% 5 Missing ⚠️
...ntral/imageintegration/datastore/datastore_impl.go 55.55% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14784   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files        2546     2546           
  Lines      186951   186956    +5     
=======================================
+ Hits        91637    91642    +5     
- Misses      88063    88065    +2     
+ Partials     7251     7249    -2
Flag Coverage Δ
go-unit-tests 49.01% <35.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@janisz
ROX-28697: use Walk instead of GetAll in image integrations
8401ffd 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the ROX-15902_use_walk_in_imageintegration branch from 336cac5 to 8401ffd Compare April 7, 2025 09:48
@janisz janisz merged commit 858cda1 into master Apr 7, 2025
88 of 89 checks passed
@janisz janisz deleted the ROX-15902_use_walk_in_imageintegration branch April 7, 2025 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

@dcaravel dcaravel Awaiting requested review from dcaravel

@mtodor mtodor Awaiting requested review from mtodor

@RTann RTann Awaiting requested review from RTann

Assignees

No one assigned

Labels

area/central

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janisz @rhacs-bot @rhybrillou