Skip to content

ROX-28697: use Walk instead of GetAll in group#14778

Merged
janisz merged 3 commits intomasterfrom
ROX-15902_use_walk_in_groups
Apr 7, 2025
Merged

ROX-28697: use Walk instead of GetAll in group#14778
janisz merged 3 commits intomasterfrom
ROX-15902_use_walk_in_groups

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Mar 27, 2025 •
edited
Loading

Description

  • CHANGELOG update is not needed
  • Documentation is not needed

Testing

  • inspected CI results

Automated testing

  • modified existing tests
  • contributed no automated tests

How I validated my change

CI

@janisz
ROX-28697: use Walk instead of GetAll in group
c61128d 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz force-pushed the ROX-15902_use_walk_in_groups branch from 5db1efa to c61128d Compare March 27, 2025 16:47
This was referenced Mar 27, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@rhacs-bot
Copy link
Contributor

rhacs-bot commented Mar 27, 2025 •
edited
Loading

Images are ready for the commit at f740fe3.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-321-gf740fe3ebf.

@codecov
Copy link

codecov bot commented Mar 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (8e68c6a) to head (f740fe3).
Report is 92 commits behind head on master.

Files with missing lines Patch % Lines
central/graphql/resolvers/groups.go 0.00% 6 Missing ⚠️
central/group/datastore/datastore_impl.go 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #14778      +/-   ##
==========================================
- Coverage   49.20%   49.01%   -0.19%     
==========================================
  Files        2533     2546      +13     
  Lines      185529   186961    +1432     
==========================================
+ Hits        91287    91639     +352     
- Misses      87005    88070    +1065     
- Partials     7237     7252      +15
Flag Coverage Δ
go-unit-tests 49.01% <53.33%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@openshift-ci
Copy link

openshift-ci bot commented Mar 27, 2025 •
edited
Loading

@janisz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-17-nongroovy-e2e-tests c61128d link false /test ocp-4-17-nongroovy-e2e-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@janisz
foreach
d12b174 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz added the auto-retest PRs with this label will be automatically retested if prow checks fails label Apr 7, 2025
@janisz
fix
f740fe3 
Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz merged commit 2eeffbb into master Apr 7, 2025
92 checks passed
@janisz janisz deleted the ROX-15902_use_walk_in_groups branch April 7, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhybrillou rhybrillou rhybrillou approved these changes

Assignees

No one assigned

Labels

area/central auto-retest PRs with this label will be automatically retested if prow checks fails

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janisz @rhacs-bot @rhybrillou